Skip to content

fix(core): avoid false transient status matches #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mukhtar003 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): avoid false transient status matches #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/core/src/shell/is-transient-command-failure.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ describe("isTransientCommandFailure", () => {
expect(isTransientCommandFailure("503 Service Unavailable")).toBe(true);
});

it("should_return_false_when_status_code_is_part_of_a_larger_number", () => {
expect(isTransientCommandFailure("port 4290 is already in use")).toBe(false);
expect(isTransientCommandFailure("test 5030 failed")).toBe(false);
expect(isTransientCommandFailure("build 5023 failed")).toBe(false);
});

it("should_return_true_when_log_contains_connection_reset", () => {
expect(isTransientCommandFailure("ECONNRESET")).toBe(true);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/shell/is-transient-command-failure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const NO_RETRY_ERROR_CODES: ReadonlySet<CaatingaErrorCodeValue> = new Set
]);

const TRANSIENT_COMMAND_FAILURE_PATTERN =
/timeout|i\/o timeout|econnreset|connection reset|503|502|429|rate limit|temporar|bad gateway|fetch failed|network error|unavailable|tx_?bad_?seq|bad sequence|bad seq/i;
/timeout|i\/o timeout|econnreset|connection reset|\b503\b|\b502\b|\b429\b|rate limit|temporar|bad gateway|fetch failed|network error|unavailable|tx_?bad_?seq|bad sequence|bad seq/i;

/**
* Decides retryability from raw log text — captured CLI output, as passed by the
Expand Down