Skip to content

refactor(core): colocate STELLAR_CLI_LAST_TESTED_VERSION with MIN_VERSION (closes #100) #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Galmanus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(core): colocate STELLAR_CLI_LAST_TESTED_VERSION with MIN_VERSION (closes #100) #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/core/src/stellar-cli/compat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import semver from "semver";
import { CaatingaError, CaatingaErrorCode } from "../errors/CaatingaError.js";
import { STELLAR_CLI_MIN_VERSION } from "./version.js";
import { STELLAR_CLI_LAST_TESTED_VERSION, STELLAR_CLI_MIN_VERSION } from "./version.js";

export { STELLAR_CLI_MIN_VERSION, parseStellarCliVersion } from "./version.js";

export const STELLAR_CLI_LAST_TESTED_VERSION = "27.0.0";
export {
STELLAR_CLI_LAST_TESTED_VERSION,
STELLAR_CLI_MIN_VERSION,
parseStellarCliVersion,
} from "./version.js";

export type CompatibilityStatus = "supported" | "untested" | "unsupported";

Expand Down
4 changes: 4 additions & 0 deletions packages/core/src/stellar-cli/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ import { CaatingaError, CaatingaErrorCode } from "../errors/CaatingaError.js";
// 22.x fails to sign `stellar contract invoke` (xdr value invalid); 23.0.0+ is required.
export const STELLAR_CLI_MIN_VERSION = "23.0.0";

// Latest Stellar CLI version this release was verified against. Kept next to
// MIN_VERSION so both version anchors live in one place (#100).
export const STELLAR_CLI_LAST_TESTED_VERSION = "27.0.0";

const STELLAR_CLI_SEMVER_REGEX = /\b(\d+\.\d+\.\d+(?:-[0-9A-Za-z-.]+)?(?:\+[0-9A-Za-z-.]+)?)\b/;

export function parseStellarCliVersion(output: string): string {
Expand Down