feature/c10-nfc-core#35
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate lock file from upstream develop and npm install so transitive deps (jest, testing-library, metro-config) match package.json. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore top-level @emnapi optional deps and align lockfile with Node 20 npm ci on Linux runners. Co-authored-by: Cursor <cursoragent@cursor.com>
Format codebase with Prettier, fix hook deps in useSessionPolicy, replace require() in PasskeyService tests, and rename AuthErrorCode type alias to avoid redeclare. Co-authored-by: Cursor <cursoragent@cursor.com>
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
Summary
This PR implements C10 — NFC protocol and session management (CLI-046 through CLI-052), delivering the core NFC transport stack required for receive/send payment flows.
Native setup & configuration (CLI-046)
react-native-nfc-manager,zod, andzustandapp.config.tswith NFC plugin, iOSNFCReaderUsageDescription, AndroidNFCpermission, and NDEF entitlementsREADME.mdanddocs/adr-nfc-library.mdNfcService abstraction (CLI-047)
NfcService.types.ts(isSupported,isEnabled,startReaderSession,startWriterSession,cancelSession)NfcService.native.ts(NDEF MIMEapplication/json)NfcService.web.tsreturning unsupportedcreateMockNfcService()for unit testsPayment request schema (CLI-048)
payment_request.v1:type,recipient,asset,amount,timestamp,expiresAtwallet/constants/assets.tsvalidateExpiry()andparsePaymentRequestFresh()helpersPayload codec (CLI-049)
NfcPayloadCodec: compact JSON encode/decode with 880-byte max guardWriter & reader sessions (CLI-050 / CLI-051)
useNfcWriter,useNfcReaderSession store & auth coordination (CLI-052)
nfcSessionStorestate machine:idle→scanning/writing→success/errornfcActiveuseSessionPolicyrespectsnfcActiveto avoid auth lock during NFC sessionsTests & docs
nfc-spike.tsfor device verificationnpm run typecheckconfiguredTest plan
npm test— 15 tests passing (schema, codec, session store)npm run typecheck— no TypeScript errorsnpx expo prebuild --clean && npx expo run:android(or iOS)nfcSpikeCheckSupport()returnssupported: trueOut of scope (follow-up PRs)
NfcAvailabilityBannerUI (CLI-053)