Port plugin to Girder 5#71
Conversation
|
@manthey I believe this is now ready for you to test out. |
| CLIENT_SOURCE_PATH = "web_client" | ||
|
|
||
| def load(self, info): | ||
| plugin.getPlugin('large_image').load(info) |
There was a problem hiding this comment.
I made this explicitly depend on the girder-large-image plugin given that that's listed as a required dependency in setup.py. If that's not right and this plugin doesn't actually depend on large_image, we should remove it from both places.
There was a problem hiding this comment.
I forgot what side effect large-image did that this plugin depended on. This plugin may no longer need large-image. Worth a test.
There was a problem hiding this comment.
Prior to my changes, it statically imported a front-end symbol from the girder-large-image plugin JS code. However, that's equivalent to just importing the one from Girder core, because they refer to the same object.
|
How should we organize the repo to simultaneously support Girder 3 and Grider 5? |
|
On most of the other repos we have been keeping an integration branch called |
3 participants
No description provided.