Closed
Conversation
titouangragnic
approved these changes
Jan 9, 2025
Hpn4
approved these changes
Jan 9, 2025
Baschtien
approved these changes
Jan 9, 2025
Collaborator
Author
|
Good for me |
Hpn4
requested changes
Jan 9, 2025
Collaborator
Hpn4
left a comment
Hpn4
left a comment
There was a problem hiding this comment.
For all cameras you create static libraries instead of shared so no DLL are created. So the cpack install will fail and we can't use any camera anymore.
| set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /FS") | ||
|
|
||
|
|
||
| add_library("${PROJECT_NAME}" STATIC |
Collaborator
There was a problem hiding this comment.
Why STATIC ? Their would be no DLL
Collaborator
There was a problem hiding this comment.
Yes, I was too focused on the problem of linking of the .exe file and in my mind making static library would still create a dll and fix the linking issue, i should have tried to cpack,i will revert this and find another solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix linking issues for the camera dlls and the holovibes.exe file