Skip to content

Rework recording#775

Merged
alexispinson merged 9 commits intodevfrom
api_record
Jan 10, 2025
Merged

Rework recording#775
alexispinson merged 9 commits intodevfrom
api_record

Conversation

@Hpn4
Copy link
Collaborator

@Hpn4 Hpn4 commented Jan 8, 2025

A lot of subsribers has been deleted allowing the notifier system to only be a GUI parts. So i have moved it to the includes/gui/notifier directory.

This PR is mainly to delete subsribers and a feature Michael ask to have: when all the frame are acquired, the UI show a progress bar for the saving.

I also fixed a couple of bugs:

  • when recording in unlimited number of frames and then clicking stop. It's not the acquisition that was stop but the saving so if we record for like 2s and then stop, on reality the file will only have 1.8s for example.
  • the record queue was not reset before recording. So when recording a second time, the record queue still has some frames of the previous record (frames acquired during one cycle of the pipe to be precise)
  • when recording, if the record queue or the input queue was overwritten, the next record will stop instantaneously with the same error while it's not true.

@Hpn4 Hpn4 marked this pull request as ready for review January 9, 2025 15:32
@Hpn4 Hpn4 linked an issue Jan 10, 2025 that may be closed by this pull request
Copy link
Collaborator

@alexispinson alexispinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems quite good for me

@Hpn4 Hpn4 linked an issue Jan 10, 2025 that may be closed by this pull request
@alexispinson alexispinson merged commit 319832f into dev Jan 10, 2025
@Hpn4 Hpn4 linked an issue Jan 15, 2025 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refacto API Processed record stops Batch size RAW bug

5 participants