Merged
Conversation
Closed
alexispinson
approved these changes
Jan 10, 2025
Collaborator
alexispinson
left a comment
There was a problem hiding this comment.
Seems quite good for me
Closed
Baschtien
reviewed
Jan 10, 2025
GustaveHerve
approved these changes
Jan 10, 2025
simon-riou
approved these changes
Jan 10, 2025
Baschtien
approved these changes
Jan 10, 2025
Open
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of subsribers has been deleted allowing the notifier system to only be a GUI parts. So i have moved it to the includes/gui/notifier directory.
This PR is mainly to delete subsribers and a feature Michael ask to have: when all the frame are acquired, the UI show a progress bar for the saving.
I also fixed a couple of bugs: