Merged
Conversation
CBlockIndex's constructor only sets lastAlgoBlocks[this->GetAlgo()] = this; and leaves other array entries at nullptr, but we need them to mirror the parent's array. That logic allows GetLastBlockIndexForAlgoFast() to jump from block to block for a given algo without hitting uninitialized pointers. Debugged this with ASAN after seeing: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior pow.cpp:354:21 in chain.h:263:9: runtime error: member call on misaligned address 0xbebebebebebebebe for type 'const CBlockIndex *', which requires 8 byte alignment
…re/digibyte into feature/8.22.0_final
This reverts commit 62961e0.
gto90
requested review from
JaredTate,
SmartArray,
digicontributer and
ycagel
ycagel
approved these changes
Jan 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Qt wallet logos.