Add LPT model #71
Merged
Add LPT model #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboucaud
reviewed
Mar 5, 2024
setup.py
Outdated
| @@ -24,5 +24,6 @@ | |||
| "optax>=0.1.4", | |||
| "scikit-learn>=1.2.0", | |||
| "wheel", | |||
| "JaxPM @ git+https://github.com/DifferentiableUniverseInitiative/JaxPM.git" | |||
There was a problem hiding this comment.
you should probably pin the version of JaxPM
| return dx.reshape([-1, 3]) | ||
|
|
||
|
|
||
| def convergence_Born(cosmo, density_planes, r, a, dx, dz, coords, z_source): |
There was a problem hiding this comment.
It's better to keep consistency in naming throughout the code.
Typically capital letter are only used for Classes and CONSTANTS.
functions => snake_case
classes => CamelCase
Suggested change
| def convergence_Born(cosmo, density_planes, r, a, dx, dz, coords, z_source): | |
| def convergence_born(cosmo, density_planes, r, a, dx, dz, coords, z_source): |
|
|
||
|
|
||
| # Define the probabilistic model | ||
| def lensingLpt( |
There was a problem hiding this comment.
Same comment
Suggested change
| def lensingLpt( | |
| def lensing_lpt( |
There was a problem hiding this comment.
Same comment applies for the file name => lpt_field.py or lpt.py is better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add an lpt model