Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packaging] Migrating to scikit-build core #22

Merged
merged 11 commits into from
Jul 8, 2024
Merged

[Packaging] Migrating to scikit-build core #22

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
605fc8a
Migrate to Scikit-build tools
ASKabalan Jun 28, 2024
015d1cc
fix
ASKabalan Jun 28, 2024
815b155
fix: some CMake fixes
henryiii Jun 28, 2024
6e26027
Migrating to Scikit build core
ASKabalan Jul 4, 2024
0b355c0
Merge branch 'push-to-pypi' into henryiii/fix/cmake
ASKabalan Jul 4, 2024
5ae64ba
Merge pull request #21 from henryiii/henryiii/fix/cmake
ASKabalan Jul 4, 2024
91bd009
Set compilers manually to avoid endless CMake loop
ASKabalan Jul 4, 2024
a66cfb0
updating to main
EiffL Jul 8, 2024
34db3cf
Bump cmake version to avoid NVHPCConfig issues
EiffL Jul 8, 2024
f63d8cf
fix argument numbers after removing halo_reduce
EiffL Jul 8, 2024
d6640e8
reverting precommit change
EiffL Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
cmake_minimum_required(VERSION 3.19...3.25)

find_program(NVHPC_CXX_BIN "nvc++" REQUIRED)
set(CMAKE_CXX_COMPILER ${NVHPC_CXX_BIN})

find_program(NVHPC_C_BIN "nvc" REQUIRED)
set(CMAKE_C_COMPILER ${NVHPC_C_BIN})
EiffL marked this conversation as resolved.
Show resolved Hide resolved

project(jaxdecomp LANGUAGES CXX CUDA)

# NVCC 12 does not support C++20
Expand All @@ -10,8 +16,9 @@ set(CMAKE_CUDA_STANDARD 17)
find_package(CUDAToolkit REQUIRED VERSION 12)
set(NVHPC_CUDA_VERSION ${CUDAToolkit_VERSION_MAJOR}.${CUDAToolkit_VERSION_MINOR})

# Build debug
# set(CMAKE_BUILD_TYPE Debug)
message(STATUS "Using CUDA ${NVHPC_CUDA_VERSION}")
# Build Release by default
set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build.")

add_subdirectory(third_party/cuDecomp)

Expand Down
Loading