Skip to content

284 refactor pulse generator severpy to inherit from abstractinstrumentserver#285

Draft
Relm-Arrowny wants to merge 12 commits into280-baseserver-abstract-class-for-tcp-servicesfrom
284-refactor-pulse_generator_severpy-to-inherit-from-abstractinstrumentserver
Draft

284 refactor pulse generator severpy to inherit from abstractinstrumentserver#285
Relm-Arrowny wants to merge 12 commits into280-baseserver-abstract-class-for-tcp-servicesfrom
284-refactor-pulse_generator_severpy-to-inherit-from-abstractinstrumentserver

Conversation

@Relm-Arrowny
Copy link
Collaborator

@Relm-Arrowny Relm-Arrowny commented Mar 16, 2026

Fixes #284 part of #274

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.00%. Comparing base (e1446f9) to head (82b4d18).
⚠️ Report is 2 commits behind head on 280-baseserver-abstract-class-for-tcp-services.

Files with missing lines Patch % Lines
...sky/common/server/pulse_generator_shanghai_tech.py 84.00% 8 Missing ⚠️
Additional details and impacted files
@@                                Coverage Diff                                 @@
##           280-baseserver-abstract-class-for-tcp-services     #285      +/-   ##
==================================================================================
- Coverage                                          100.00%   99.00%   -1.00%     
==================================================================================
  Files                                                  30       31       +1     
  Lines                                                 752      803      +51     
==================================================================================
+ Hits                                                  752      795      +43     
- Misses                                                  0        8       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny linked an issue Mar 17, 2026 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor pulse_generator_sever.py to inherit from AbstractInstrumentServer

1 participant