Skip to content

280 Implement AbstractInstrumentServer with TCP/IPv6 support#282

Open
Relm-Arrowny wants to merge 23 commits intomainfrom
280-baseserver-abstract-class-for-tcp-services
Open

280 Implement AbstractInstrumentServer with TCP/IPv6 support#282
Relm-Arrowny wants to merge 23 commits intomainfrom
280-baseserver-abstract-class-for-tcp-services

Conversation

@Relm-Arrowny
Copy link
Collaborator

@Relm-Arrowny Relm-Arrowny commented Mar 13, 2026

Fixes #280 as part of #274

  • Implemented AbstractInstrumentServer to handle TCP data for controlling hardware.
  • Defined three abstract methods to manage hardware communication.
  • Implemented command_registry and basic server commands.

Instructions to reviewer on how to test:

  1. Check test cover all use case.
  2. Check interface make sense.
  3. Run test and ensure they pass.

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@Relm-Arrowny Relm-Arrowny linked an issue Mar 13, 2026 that may be closed by this pull request
6 tasks
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d61285b) to head (3ea6058).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #282    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           28        30     +2     
  Lines          638       752   +114     
==========================================
+ Hits           638       752   +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny changed the title 280 baseserver abstract class for tcp services 280 Implement AbstractInstrumentServer with TCP/IPv6 support Mar 16, 2026
@Relm-Arrowny Relm-Arrowny requested a review from a team March 16, 2026 15:33
@Relm-Arrowny Relm-Arrowny marked this pull request as ready for review March 16, 2026 15:33
@Relm-Arrowny
Copy link
Collaborator Author

Relm-Arrowny commented Mar 16, 2026

@fajinyuan @Villtord @oliwenmandiamond @DG-At-Diamond
Not sure the @DiamondLightSource/smg review tag is working so everyone get a poke here :p

@oliwenmandiamond
Copy link
Collaborator

What is the use case for this?

@Relm-Arrowny
Copy link
Collaborator Author

Relm-Arrowny commented Mar 16, 2026

What is the use case for this?

#274 @fajinyuan wanted it to be production ready, rather than just script flying around in the user_script.

…ract-class-for-tcp-services' into 280-baseserver-abstract-class-for-tcp-services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BaseServer abstract class for tcp services.

2 participants