Open
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 76.90% 76.68% -0.22%
==========================================
Files 31 31
Lines 4533 4551 +18
Branches 322 327 +5
==========================================
+ Hits 3486 3490 +4
- Misses 978 991 +13
- Partials 69 70 +1 🚀 New features to boost your workflow:
|
ndevenish
requested changes
Mar 11, 2026
ndevenish
requested changes
Mar 11, 2026
Comment on lines
+230
to
+231
| except Exception as e: | ||
| self.log.warning(f"Failed to set DCID on trace span: {e}") |
Contributor
There was a problem hiding this comment.
what is this exception protecting against?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logic to extract DCID from messages and inject into span context.