Skip to content

Migrate detector LUT to use config server#1510

Merged
jacob720 merged 33 commits intomainfrom
1509_use_config_server_for_detector_lut
Mar 25, 2026
Merged

Migrate detector LUT to use config server#1510
jacob720 merged 33 commits intomainfrom
1509_use_config_server_for_detector_lut

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

@jacob720 jacob720 commented Dec 10, 2025

Fixes #1509

Link to dodal PR (if required): DiamondLightSource/dodal#1776

Instructions to reviewer on how to test:

  1. Check config is read through config server

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@jacob720 jacob720 requested a review from a team as a code owner December 10, 2025 11:12
@jacob720 jacob720 marked this pull request as draft December 10, 2025 11:13
@jacob720 jacob720 added the dev experience Changes relating to developer experience label Dec 10, 2025
@jacob720 jacob720 force-pushed the 1509_use_config_server_for_detector_lut branch from 8a976f8 to 82bab99 Compare January 6, 2026 11:27
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (829a5ce) to head (95a880a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1510   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files         155      155           
  Lines        8492     8494    +2     
=======================================
+ Hits         7887     7889    +2     
  Misses        605      605           
Components Coverage Δ
i24 SSX 77.35% <100.00%> (+0.02%) ⬆️
hyperion 98.59% <ø> (ø)
other 98.30% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob720 jacob720 force-pushed the 1509_use_config_server_for_detector_lut branch from ce42c0a to 7bb4a57 Compare March 3, 2026 18:33
@jacob720 jacob720 changed the base branch from main to 1504_read_beamlineParameters_through_config_server March 3, 2026 18:33
@jacob720 jacob720 marked this pull request as ready for review March 3, 2026 18:38
Base automatically changed from 1504_read_beamlineParameters_through_config_server to main March 13, 2026 16:21
@jacob720 jacob720 force-pushed the 1509_use_config_server_for_detector_lut branch from 83fd40b to 1daf771 Compare March 25, 2026 14:20
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jacob720 jacob720 enabled auto-merge (squash) March 25, 2026 16:14
@jacob720 jacob720 merged commit 62c0c9a into main Mar 25, 2026
26 of 27 checks passed
@jacob720 jacob720 deleted the 1509_use_config_server_for_detector_lut branch March 25, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate detector LUTs to daq config server

2 participants