fix: improve default error handling #1379 #1409#1439
Draft
Conversation
accdd8c to
c5ab6b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
+ Coverage 95.19% 95.26% +0.07%
==========================================
Files 43 43
Lines 3119 3125 +6
==========================================
+ Hits 2969 2977 +8
+ Misses 150 148 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c5ab6b3 to
883b09e
Compare
883b09e to
05150ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1379
Fixes #1409
Both issues related to error handling in the REST client.
1379 - Catches 'UnauthorisedAccessError
explicitly instead of string-matching onBlueskyRemoteControlError`.1409 - Expands the exception hierarchy so each
HTTP status code raises a distinct typed exception rather than bundling
everything into
BlueskyRemoteControlError.Tests
runcommand