Skip to content

fix: change default from 3 to None #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shree-iyengar-dls wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: change default from 3 to None #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c857ca7
fix: change default from 3 to None
shree-iyengar-dls Mar 10, 2026
d4b4b42
refactor: remove None from precision line
shree-iyengar-dls Mar 10, 2026
9701397
refactor: change precision default to None in class StatusView
shree-iyengar-dls Mar 10, 2026
a5d0f61
refactor: add None to type hint of precision in class StatusView
shree-iyengar-dls Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/blueapi/worker/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ class StatusView(BlueapiBaseModel):
description="Target value operation of progress, if known", default=None
)
unit: str = Field(description="Units of progress", default="units")
precision: int = Field(
description="Sensible precision of progress to display", default=3
precision: int | None = Field(
description="Sensible precision of progress to display", default=None
)
done: bool = Field(
description="Whether the operation this status describes is complete",
Expand Down
2 changes: 1 addition & 1 deletion src/blueapi/worker/task_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ def _on_status_event(
initial=initial,
target=target,
unit=unit or "units",
precision=precision or 3,
precision=precision,
done=status.done,
percentage=percentage,
time_elapsed=time_elapsed,
Expand Down