-
Notifications
You must be signed in to change notification settings - Fork 5
validate hinted attributes on subcontrollers #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 92.34% 92.36% +0.02%
==========================================
Files 40 40
Lines 2077 2083 +6
==========================================
+ Hits 1918 1924 +6
Misses 159 159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We're currently not checking for non generic alias types e.g.
Might also be good to validate hinted subcontrollers, though I guess they're not usually dot-accessed. e: pushed something, setting as draft until I fix some logic with how hinting as an Attribute should work |
dcd79d6
to
ac94896
Compare
b50ee48
to
6a666e1
Compare
Co-authored-by: Gary Yendell <[email protected]>
6a666e1
to
2ca1bb8
Compare
Oversight from #187