Skip to content

Conversation

jsouter
Copy link
Contributor

@jsouter jsouter commented Sep 10, 2025

Oversight from #187

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.36%. Comparing base (9c2042a) to head (6a666e1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   92.34%   92.36%   +0.02%     
==========================================
  Files          40       40              
  Lines        2077     2083       +6     
==========================================
+ Hits         1918     1924       +6     
  Misses        159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsouter
Copy link
Contributor Author

jsouter commented Sep 10, 2025

We're currently not checking for non generic alias types e.g.

class MyController:
    my_attr: AttrR
    my_attr_unknown_access_mode: Attribute

Might also be good to validate hinted subcontrollers, though I guess they're not usually dot-accessed.

e: pushed something, setting as draft until I fix some logic with how hinting as an Attribute should work

@jsouter jsouter force-pushed the validate-subcontroller-attrs branch from dcd79d6 to ac94896 Compare September 10, 2025 13:07
@jsouter jsouter marked this pull request as draft September 10, 2025 14:23
@jsouter jsouter force-pushed the validate-subcontroller-attrs branch from b50ee48 to 6a666e1 Compare September 15, 2025 07:38
@jsouter jsouter force-pushed the validate-subcontroller-attrs branch from 6a666e1 to 2ca1bb8 Compare October 6, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants