Make STL loader/writer and PLY writer work again #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing performActionBasedOnOrientationSystem
…side, comment out some legacy code
Comment on lines
39
to
+44
| static inline void performActionBasedOnOrientationSystem(aType& varToHandle, void (*performOnCertainOrientation)(aType& varToHandle)) | ||
| { | ||
| performOnCertainOrientation(varToHandle); | ||
| } |
There was a problem hiding this comment.
I decided these functions make no sense for geometries (as an appropriate geometry transform in a collection can be used instead of changing the mesh data), see git blame in PLY loader
| uint32_t topHierarchyLevel; | ||
| IAssetLoader::IAssetLoaderOverride* loaderOverride; | ||
| private: | ||
| const std::string_view getPipelineCacheKey(bool withColorAttribute) { return withColorAttribute ? "nbl/builtin/pipeline/loader/STL/color_attribute" : "nbl/builtin/pipeline/loader/STL/no_color_attribute"; } |
There was a problem hiding this comment.
everything to do with a pipeline needs to go
…into yas_mesh_loaders
…ation in IAssetManager
…into yas_mesh_loaders
…into yas_mesh_loaders
|
@kevyuu can you review this? |
…xt in binary writer
…lling std::find_first_of
…into yas_mesh_loaders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.