Skip to content

Comments

Unstable#11

Open
Sharmaji04 wants to merge 107 commits intomainfrom
unstable
Open

Unstable#11
Sharmaji04 wants to merge 107 commits intomainfrom
unstable

Conversation

@Sharmaji04
Copy link

Himanshu op

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 30, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.64%.

Quality metrics Before After Change
Complexity 10.53 🙂 9.92 🙂 -0.61 👍
Method Length 104.96 🙂 105.20 🙂 0.24 👎
Working memory 11.61 😞 11.46 😞 -0.15 👍
Quality 52.73% 🙂 53.37% 🙂 0.64% 👍
Other metrics Before After Change
Lines 1992 2035 43
Changed files Quality Before Quality After Quality Change
Cricket_info.py 81.53% ⭐ 81.53% ⭐ 0.00%
advice.py 88.45% ⭐ 88.45% ⭐ 0.00%
any_dl.py 27.30% 😞 29.11% 😞 1.81% 👍
carbon.py 60.02% 🙂 60.00% 🙂 -0.02% 👎
cc_tools.py 68.67% 🙂 68.67% 🙂 0.00%
collage.py 24.22% ⛔ 24.26% ⛔ 0.04% 👍
fban.py 49.20% 😞 49.74% 😞 0.54% 👍
github_search.py 37.61% 😞 37.68% 😞 0.07% 👍
harem.py 80.30% ⭐ 80.08% ⭐ -0.22% 👎
imdb.py 36.80% 😞 36.88% 😞 0.08% 👍
music_player.py 54.45% 🙂 54.90% 🙂 0.45% 👍
rom_search.py 66.86% 🙂 61.87% 🙂 -4.99% 👎
shazam.py 58.65% 🙂 58.65% 🙂 0.00%
unzip.py 42.14% 😞 42.14% 😞 0.00%
user-agent-info.py 56.14% 🙂 56.14% 🙂 0.00%
webtools.py 63.17% 🙂 63.17% 🙂 0.00%
helper_files/dl_.py 68.41% 🙂 68.76% 🙂 0.35% 👍
helper_files/dl_helpers.py 81.47% ⭐ 81.50% ⭐ 0.03% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
any_dl.py download_ 36 ⛔ 473 ⛔ 22 ⛔ 10.58% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
music_player.py play_m 24 😞 479 ⛔ 17 ⛔ 19.79% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
collage.py create_s_collage 27 😞 289 ⛔ 15 😞 23.40% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
collage.py wow_collage 22 😞 298 ⛔ 16 ⛔ 25.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
fban.py fetch_all_fed 29 😞 196 😞 16 ⛔ 26.34% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants