Skip to content

chore: upgrade to hyper v1 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: upgrade to hyper v1 #36

wants to merge 4 commits into from

Conversation

allan2
Copy link

@allan2 allan2 commented Jul 30, 2025

No description provided.

LucFauvel
LucFauvel requested changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@LucFauvel LucFauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

src/proxy/utils.rs
match client.request(req).await {
Ok(response) => response,
Err(e) => {
error!("hyper error: {}", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep the error log here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9f56444.

@allan2 allan2 mentioned this pull request Jul 30, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucFauvel LucFauvel LucFauvel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allan2 @LucFauvel