Skip to content

Add fixed-region options for video recording - #32

Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit into
masterfrom
video-fixed-region
Nov 2, 2026
Merged

Marc-André Moreau (mamoreau-devolutions) merged 1 commit into
masterfrom
video-fixed-region

Conversation

@alistek

Copy link
Copy Markdown
Contributor

Summary

  • The Video tab's Region gear opens Region options like the Image tab: Fixed region with Width and Height (16–8192 px), then Set position with X and Y (Windows), then the existing frame rate and countdown rows.
  • With Fixed region on, recording opens the overlay in the existing fixed-frame mode (VideoFixed) at the configured size; 1–4 still switch to the standard sizes. With Set position on, it records at the saved X/Y without the overlay and reports an error if that rectangle is off every screen.
  • The video region is stored separately from the image one (video_fixed_size, default 1920×1080; capture_window.video_fixed / video_fixed_at). The Area label shows Region (W × H), Reset restores it, and presets saved from it use a new video-fixed mode.
  • Windows: both Region options panels gain Select region on screen…. It keeps the panel's current values, opens the overlay, and takes the size (and, with Set position, the position) from a dragged rectangle or clicked window, then reopens the Capture window with the options panel. Esc returns without changes.
  • macOS gets the video size options but not Set position or Select region, since saved positions there need display-grid confirmation that recordings don't have yet.
  • The recording rows stay last and the region rows are read by count, so older 2-value submissions (apply:video:selection:[3,7]) still apply only the frame rate and countdown.
  • README describes the new options.

Validation

  • cargo build --release --locked -p jiffshot -p jiffshot-cli (Windows x64)
  • cargo test --release --locked --workspace: all pass (app 72, workflow 123 + 1 ignored), including new tests for the video Region options, Select region on screen, and the Capture window action.
  • cargo clippy --no-deps -p jiffshot -p jiffshot-workflow --all-targets: no warnings on changed lines (the existing warnings are unchanged).
  • Tried manually in the Windows app with a scratch profile.
  • Not built locally for macOS; relying on CI for that target.

🤖 Generated with Claude Code

The Video tab's Region gear now opens Region options like the Image tab:
Fixed region with Width and Height (16-8192), and on Windows Set position
with X and Y, followed by the frame rate and countdown. A fixed region
opens the overlay with a rectangle of that size to place; with Set
position it records at the saved position without the overlay. The video
region is kept separately from the image one (default 1920x1080), and
presets saved from it use the new "video-fixed" mode.

On Windows, both Region options panels also get "Select region on
screen...", which takes the size (and, with Set position, the position)
from a dragged rectangle or a clicked window, then reopens the options.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) merged commit e924b9f into master Nov 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants