feat: support for both Send and !Send Framed impls #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using GATs we achieve genericity over Send and Sync marker traits. The `FramedRead` and `FramedWrite` can now be used in both single-threaded and multi-threaded contexts.
|
👍 works great for me, thanks! |
|
Great to hear! Can you approve the PR, please? @probakowski |
probakowski
approved these changes
Sep 5, 2023
|
Thank you @probakowski |
thenextman
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using GATs we achieve genericity over Send and Sync marker traits. The
FramedReadandFramedWritetraits can now be used in both single-threaded and multi-threaded contexts.cc @probakowski @ibeckermayer does it looks good to you?
This is an alternative to #188 that is working for both web and native clients.