chore(lint): add Biome linter (config, script, CI gate) - #107
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The repo type-checked but had no linter. Add Biome (lint-only, formatter disabled to avoid churn) wired into package.json and the CI workflow. Config keeps meaningful correctness/suspicious/complexity rules and disables domains irrelevant to a local CLI tool (a11y on the static dashboard HTML) and pure-style noise (useTemplate). The linter surfaced two real tidies, both applied: an implicit-return forEach callback in config.ts (now explicit void) and a manual &&-guard in dashboard.client.js (now optional chaining). Lint, typecheck, 93 tests, and dashboard smoke all pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The repo type-checked but had no linter. This adds Biome (lint-only; formatter disabled to avoid a 25-file style churn), wired into
package.json(bun run lint) and the CI workflow as a gate.Config choices
Keeps the meaningful
correctness/suspicious/complexityrules; disables domains irrelevant to a local CLI tool —a11y(fires only on the static dashboard HTML) and the pure-styleuseTemplatenoise.Real issues the linter caught (both fixed)
config.ts: an implicit-returnforEachcallback → made explicitly void.dashboard.client.js: a manual&&guard → optional chaining (behavior-identical in the ternary condition).Verification
bun run lintexit 0, typecheck clean, 93 tests pass, dashboard smoke passes.🤖 Generated with Claude Code