Merge pull request #4 from DevboiDesigns/dev

configure env
DevboiDesigns · Feb 3, 2025 · 0cf0796 · 0cf0796
2 parents e01cba4 + 057d1b4
commit 0cf0796
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 16 deletions.
diff --git a/.env.example b/.env.example
@@ -0,0 +1 @@
+VITE_API_URL=
diff --git a/.gitignore b/.gitignore
@@ -22,3 +22,4 @@ dist-ssr
 *.njsproj
 *.sln
 *.sw?
+.env.*
diff --git a/README.md b/README.md
@@ -2,7 +2,7 @@
 
 The `album-viewer` web component fetches and displays albums from a specified [Bandcamp](https://bandcamp.com) artist
 
-![version](https://img.shields.io/badge/v1.0.1-RELEASE-8A2BE2)
+![version](https://img.shields.io/badge/v2.0.1-RELEASE-8A2BE2)
 
 ---
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "album-viewer",
   "private": false,
-  "version": "1.0.1",
+  "version": "2.0.1",
   "type": "module",
   "files": [
     "dist",
@@ -59,5 +59,8 @@
     "album viewer webcomponent",
     "album-viewer-webcomponent",
     "album viewer webcomponents"
-  ]
+  ],
+  "dependencies": {
+    "dotenv": "^16.4.7"
+  }
 }
diff --git a/src/album-viewer.ts b/src/album-viewer.ts
@@ -1,6 +1,6 @@
 import { LitElement, css, html } from "lit"
 import { customElement, property } from "lit/decorators.js"
-import { BASE_URL } from "./utils/base.url"
+import { API_URL } from "./utils/base.url"
 import { BANDCAMP_URL } from "./utils/bandcamp.url"
 
 @customElement("album-viewer")
@@ -18,7 +18,7 @@ export class AlbumViewer extends LitElement {
   }
 
   async fetchAlbumData() {
-    const requestUrl = `${BASE_URL()}?name=${this.name}`
+    const requestUrl = `${API_URL}/album-viewer/?name=${this.name}`
     try {
       const response = await fetch(requestUrl, {
         method: "GET",

diff --git a/src/utils/base.url.ts b/src/utils/base.url.ts
@@ -1,7 +1,3 @@
-const BASE_URL = (isLocal: boolean = false) => {
-  return isLocal
-    ? "http://localhost:3000/albums"
-    : "https://devboi-music-api-3aba476986fd.herokuapp.com/albums"
-}
+const API_URL = import.meta.env.VITE_API_URL
 
-export { BASE_URL }
+export { API_URL }
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "compilerOptions": {
     "target": "es2017",
-    "module": "es2015",
+    "module": "es2020",
     "moduleResolution": "node",
     "lib": ["es2017", "dom"],
     "experimentalDecorators": true,

diff --git a/types/utils/base.url.d.ts b/types/utils/base.url.d.ts
@@ -1,2 +1,2 @@
-declare const BASE_URL: (isLocal?: boolean) => "http://localhost:3000/albums" | "https://devboi-music-api-3aba476986fd.herokuapp.com/albums";
-export { BASE_URL };
+declare const API_URL: any;
+export { API_URL };
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,3 +22,4 @@ dist-ssr @@
     *.njsproj
     *.sln
     *.sw?
+    .env.*