fix(ci): use focus URI on non-macOS to satisfy clippy - #85
Conversation
Ubuntu CI treats the macOS-only open path as an unused binding after the v0.3.7 integration expansion merge.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes a Linux/Ubuntu CI failure introduced by macOS-only deep-link handling by ensuring the focus URI is consumed on non-macOS builds and returning a clear, non-no-op error when deep-link opening isn’t supported.
Changes:
- Adds a non-macOS
cfgbranch that returns an error forAction::OpenFocusedThreaddeep-link attempts. - Includes the computed focus URI in the non-macOS error message to avoid
unused variable: urlwarnings and improve diagnostics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
## Summary - Replace `brew services list | awk/grep` with `--json | jq` in finalize-release workflow and smoke-formula script to fix Intel `Broken pipe` flakes under `pipefail`. - Align leftover `0.3.6` drift in `apps/microbridge-ui/src-tauri/Cargo.toml` and `package-lock.json` to `0.3.7`. - Add `docs/releases/v0.3.7.md` and a `route_action` + `OpenFocusedThread` unit test proving non-macOS URI error / macOS Ok path (#85 regression). ## Test plan - [x] `cargo clippy -p microbridged --all-targets -- -D warnings` - [x] `cargo test -p microbridged` - [ ] CI: `rust (ubuntu-latest)`, `rust (macos-latest)`, `ui` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added automatic discovery of installed agent runtimes at daemon startup. * Added an embedded local MCP endpoint at `http://127.0.0.1:9190/mcp`. * Added universal focus deep-linking via agent key presses. * Introduced a community adapter SDK. * **Upgrade Notes** * No migration is required; integrations may need reconnection after upgrading if adapters were disabled. * Focus deep-linking is supported on macOS; other platforms report an explanatory error. * **Documentation** * Added release notes for version 0.3.7. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
unused variable: urlinstate.rson Ubuntu (deep-linkopenis macOS-only).Test plan
cargo clippy -p microbridged --all-targets -- -D warningsMade with Cursor