fix: harden v0.2.1 Homebrew smoke readiness - #47
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
There was a problem hiding this comment.
Pull request overview
Hardens the macOS Homebrew smoke/verification harness for v0.2.1 by extending readiness waits, validating the installed app version from Info.plist, and capturing diagnostics on failures so release finalization is less prone to flaky runner timing.
Changes:
- Add a failure-only diagnostics path to the formula smoke script (services status + log tail + bundle metadata).
- Replace
defaults readwithPlistBuddyforCFBundleShortVersionStringreads. - Expand readiness loops and apply equivalent checks to the public-install verification in the release finalization workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/smoke-formula.sh | Adds diagnostics-on-failure and strengthens brew/app readiness checks in the local formula smoke harness. |
| .github/workflows/finalize-release.yml | Applies the same readiness checks to the final “public tap install” verification step before promoting a release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| APP_PID="" | ||
| for _ in {1..10}; do | ||
| for _ in {1..30}; do | ||
| APP_PID="$(pgrep -f "$APP/Contents/MacOS/" | head -1 || true)" |
| APP_PID="" | ||
| for _ in {1..10}; do | ||
| for _ in {1..30}; do | ||
| APP_PID="$(pgrep -f "$APP/Contents/MacOS/" | head -1 || true)" |
What changed
Evidence
This repairs the smoke harness that stopped release run 29656672177 before any prerelease was published.