refactor: Add On My Own 아키텍쳐 이주 #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Add On My Own architecture and adjusts the bottom sheet design to improve consistency and address a bug in the schedule default time dropdown. Key changes include:
- Migrating Add On My Own components and related styles to the new LectureBottomSheet folder.
- Replacing the EditSchedule modal with an AnimatePresence-powered bottom sheet.
- Updating imports to use the new file structure and removing the old modal-based EditSchedule.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/domain/Timetable/components/LectureBottomSheet/DaySelector/index.tsx | Introduces a DaySelector component for day selection. |
| src/domain/Timetable/components/LectureBottomSheet/CloseButton/* | Adds a CloseButton component with dedicated styling. |
| src/domain/Timetable/components/LectureBottomSheet/AddOnMyOwn/* | Implements the core Add On My Own component and related types/styles. |
| src/domain/Timetable/components/LectureBottomSheet/AddClass/* | Updates AddClass components to adjust import paths and utilize the new CloseButton. |
| src/components/timetable/Grid/LectureSticker/ScheduledLecture.tsx | Refactors EditSchedule integration using AnimatePresence instead of createPortal. |
| src/common/components/TimeSelector/* | Updates TimeSelector to accept and use an initial value via new props. |
Comments suppressed due to low confidence (2)
src/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard/style.css.ts:1
- The filename 'SerchLectureCard' appears to be a typo; for clarity and consistency, consider renaming it to 'SearchLectureCard'.
import { style } from '@vanilla-extract/css'
src/domain/Timetable/components/LectureBottomSheet/AddClass/SearchResult/index.tsx:7
- The imported component 'SearchLectureCard' is being sourced from a file with a misspelled name ('SerchLectureCard'); the file should be renamed accordingly for consistency.
import SearchLectureCard from '@/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard'
Virtuso1225
approved these changes
May 17, 2025
| }) | ||
|
|
||
| const onSubmit = (data: AddOnMyOwnForm) => { | ||
| if (timetableId === undefined) return |
There was a problem hiding this comment.
여기서 단순 return만 해도 괜찮을까용? 에러 처리 관렪서 handleSubmit 에서 토스트 띄우려면 throw error를 해야하려나 싶은
There was a problem hiding this comment.
일리있는 말씀이십니다
근데 사실 이거 발생할 가능성이 없는 예외 처린데 왜 해놨었지
타입 상 이슈도 없네..
요 라인 그냥 지워도 될까요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
☑️ 체크 사항
❗ Related Issues