Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call a DX event after using an HTML draggable element (T1260277) #28541

Draft
wants to merge 3 commits into
base: 24_2
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions e2e/testcafe-devextreme/tests/common/eventsEngine.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
import { ClientFunction, Selector } from 'testcafe';
import url from '../../helpers/getPageUrl';

fixture.disablePageReloads`Events`
.page(url(__dirname, '../container.html'));

const init = ClientFunction(() => {
const markup = `<div class="dx-viewport demo-container">
<div id="draggable" draggable="true" style="width: 200px; height: 200px; background-color: red;"></div>
<div id="target" style="width: 200px; height: 200px; background-color: black;"></div>
<div>hoverStartTriggerCount</div>
<div id="hoverStartTriggerCount">0</div>
<div>hoverEndTriggerCount</div>
<div id="hoverEndTriggerCount">0</div>
</div>`;

$('#container').html(markup);

const { DevExpress } = (window as any);

let hoverStartTriggerCount = 0;
let hoverEndTriggerCount = 0;

DevExpress.events.on($('#target'), 'dxhoverstart', () => {
hoverStartTriggerCount += 1;

$('#hoverStartTriggerCount').text(hoverStartTriggerCount);
});

DevExpress.events.on($('#target'), 'dxhoverend', () => {
hoverEndTriggerCount += 1;

$('#hoverEndTriggerCount').text(hoverEndTriggerCount);
});
});

test('The `dxhoverstart` event should be triggered after dragging and dropping an HTML draggable element (T1260277)', async (t) => {
const draggable = Selector('#draggable');
const target = Selector('#target');
const hoverStartTriggerCount = Selector('#hoverStartTriggerCount');
const hoverEndTriggerCount = Selector('#hoverEndTriggerCount');

await t
.drag(draggable, 0, 400, { speed: 1 });

// `.drag` does not trigger the `pointercancel` event.
// A sequence of `.drag` calls behaves like a single drag&drop operation,
// and each call does not trigger the `pointerup` event.
// Even if it did, the `pointercancel` event would not be triggered as specified in:
// https://www.w3.org/TR/pointerevents/#suppressing-a-pointer-event-stream
// This is a hack to test the event engine's logic.
await t.dispatchEvent(draggable, 'pointercancel');

await t
.drag(target, 0, 400, { speed: 1 });

await t.expect(hoverStartTriggerCount.textContent).eql('1');
await t.expect(hoverEndTriggerCount.textContent).eql('1');
}).before(async () => {
await init();
});
3 changes: 2 additions & 1 deletion packages/devextreme/js/__internal/events/pointer/m_mouse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ const eventMap = {
dxpointerdown: 'mousedown',
dxpointermove: 'mousemove',
dxpointerup: 'mouseup',
dxpointercancel: '',
// `dragstart` is used for safari: https://bugs.webkit.org/show_bug.cgi?id=222632
dxpointercancel: 'pointercancel dragstart',
dxpointerover: 'mouseover',
dxpointerout: 'mouseout',
dxpointerenter: 'mouseenter',
Expand Down
Loading