(chore) Refactor the code around parsed and entry #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes a couple of things to make both apis be more similar. There was an error in parsed where toSchemeLess would return a protocol-less version. This is fixed. toRelative does not make sense without a 'base' url (relative to what?). node's path.relative requires 2 params. So it is now deprecated 4 new functions, across 3 new files were created to avoid code dup. 2 of them are exposed in the barrel file, since they work on strings. The other two are not since they require a valid URL object, which is not validated, hence, not exposed. Some improvement, IMHO, to the docs.
f-elix
requested changes
Feb 5, 2025
patrickM288
approved these changes
Feb 5, 2025
Co-authored-by: Felix Guerin <[email protected]>
Co-authored-by: Felix Guerin <[email protected]>
f-elix
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes a couple of things to make both apis be more similar.
There was an error in parsed where toSchemeLess would return a protocol-less version. This is fixed.
toRelative does not make sense without a 'base' url (relative to what?). node's path.relative requires 2 params.
So it is now deprecated
4 new functions, across 3 new files were created to avoid code dup. 2 of them are exposed in the barrel file, since they work on strings. The other two are not since they require a valid URL object, which is not validated, hence, not exposed.
Some improvement, IMHO, to the docs.