Skip to content

fix(mcp): tighten ingest traces schema for strict clients#757

Merged
DeusData merged 1 commit into
DeusData:mainfrom
dpersek:codex/issue-731-vs-schema
Jul 3, 2026
Merged

fix(mcp): tighten ingest traces schema for strict clients#757
DeusData merged 1 commit into
DeusData:mainfrom
dpersek:codex/issue-731-vs-schema

Conversation

@dpersek

@dpersek dpersek commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Declare supported ingest_traces item fields in the generated MCP schema.
  • Set traces.items.additionalProperties to false for strict clients such as Visual Studio Copilot.
  • Add a parsed tools/list regression test covering the nested schema path.

Why

Fixes #731.

Visual Studio Copilot rejects codebase_memory_ingest_traces because the nested trace item object schema does not explicitly set additionalProperties: false. The schema now closes that object while still advertising the existing trace payload shape: caller, callee, and optional count.

Tests

  • build/c/test-runner mcp - passed, 122 tests.
  • git diff --check - passed.
  • make -f Makefile.cbm test - built and ran, but failed outside the MCP path with local listener/offline clone environment failures.
  • make -f Makefile.cbm lint-ci - blocked locally because cppcheck is not installed.

Scope

  • No runtime trace ingestion behavior changes.
  • No tool names or handler dispatch changes.
  • No manual Visual Studio smoke test was performed.

Signed-off-by: Dustin Persek <dustin.persek@protonmail.com>
@dpersek dpersek marked this pull request as ready for review July 2, 2026 04:31
@dpersek dpersek requested a review from DeusData as a code owner July 2, 2026 04:31
@DeusData DeusData added bug Something isn't working editor/integration Editor compatibility and CLI integration priority/normal Standard review queue; useful PR with ordinary maintainer urgency. labels Jul 3, 2026
@DeusData

DeusData commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Thanks for the strict-client schema fix for #731. Triage: MCP/editor integration compatibility bug.

Review will check the generated tools/list schema shape for strict clients and ensure the actual ingest_traces runtime behavior is unchanged. Nested additionalProperties:false is useful, but it needs to stay aligned with the advertised trace fields.

@DeusData

DeusData commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Thanks for the precise fix — we verified ingest_traces was the only bare propertyless object schema in the entire TOOLS array, which matches VS complaining exactly there, and your parsed tools/list test is a genuine guard. The declared caller/callee/count fields now become the contract for the future real implementation, which is a nice bonus. Merging — we'll ask the reporter on #731 to verify in VS.

@DeusData DeusData merged commit fa12a38 into DeusData:main Jul 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working editor/integration Editor compatibility and CLI integration priority/normal Standard review queue; useful PR with ordinary maintainer urgency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Add support for Visual Studio GitHub Copilot for codebase-memory-mcp

2 participants