Make install hooks opt-in via --hooks#753
Open
Andy11-cpu wants to merge 1 commit into
Open
Conversation
PreToolUse and SessionStart augmenter hooks are no longer installed by default. Pass --hooks to install to opt in. Install plan receipts omit hook paths unless --hooks is set. Signed-off-by: Andy11-cpu <canada11@duck.com>
4 tasks
DeusData
added
enhancement
Owner
|
Thanks for splitting out the hook opt-in behavior. Triage: installer/editor-integration UX change, currently conflicting. Please rebase on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--hookstoinstallto opt in--hooksis setMotivation
Split from #625 — avoids spawning hook augmenters on every Grep/Glob unless the user explicitly opts in.
Test plan
cli_install_plan_hooks_opt_in_defaultintest_cli.cmake -f Makefile.cbm test(CI)Signed-off-by: Andy11-cpu canada11@duck.com