Skip to content

Revert vscode launch config#729

Merged
tophyr merged 2 commits intoDescentDevelopers:mainfrom
tophyr:pr/revert-vscode-launch-config
Jan 21, 2026
Merged

Revert vscode launch config#729
tophyr merged 2 commits intoDescentDevelopers:mainfrom
tophyr:pr/revert-vscode-launch-config

Conversation

@tophyr
Copy link
Contributor

@tophyr tophyr commented Jan 21, 2026

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Allowing specific-IDE configurations like settings.json, launch.json etc is great for tightly-knit or homogenous developer setups, but it gets hard in wide-ranging cross-platform OSS projects where people might use different toolchains or even different setups within the same toolchain.

Related Issues

Reverts #728

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Not everyone has blank launch configurations - some users have a user-level (not project-level) gitignore that covers .vscode/* which enables them to have their own launch.json, and so shipping a premade configuration would clobber them.
Allowing specific-IDE configurations like settings.json, launch.json etc is great for tightly-knit or homogenous developer setups, but it gets hard in wide-ranging cross-platform OSS projects where people might use different toolchains or even different setups within the same toolchain.
@tophyr tophyr merged commit 156cba8 into DescentDevelopers:main Jan 21, 2026
8 checks passed
@tophyr tophyr deleted the pr/revert-vscode-launch-config branch January 21, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant