Enable logging in modules#718
Open
winterheart wants to merge 2 commits intoDescentDevelopers:mainfrom
Open
Conversation
winterheart
force-pushed
the
log_in_modules
branch
from
82015d1 to
15cf1c7
Compare
Lgt2x
reviewed
Jun 3, 2025
Member
Lgt2x
left a comment
Lgt2x
left a comment
There was a problem hiding this comment.
Nice work! There are a few DLLmprintf calls remaining, mostly in chat_api.cpp and mt_net.cpp, maybe they should be converted to LOG_SOMETHING as well?
I'll also test on Windows when I'll be on my desktop, you never know what it can do with DLLs.
winterheart
force-pushed
the
log_in_modules
branch
from
15cf1c7 to
f0d427c
Compare
Collaborator
Author
|
Additional mprintf() replacing that found in second run. |
winterheart
force-pushed
the
log_in_modules
branch
from
f0d427c to
b715df5
Compare
Implementing chained appender initialization scenario for plog.
Implementing chained appender initialization scenario for plog. # Conflicts: # netgames/dmfc/dmfcbase.cpp
winterheart
force-pushed
the
log_in_modules
branch
from
b715df5 to
87affb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR enables logging with plog in shared modules (netcon and netgames). Previously used DLLmprintf() was no-op.
For each module added new function for initialization and accessing to main logger instance.
Related Issues
Screenshots (if applicable)
Checklist
Additional Comments