Draft
Conversation
These pragmas were not useful or considered by any compilre, so we can safely remove them now.
Initialize variables that may not be assigned before being used
Using a pragma message here is not very useful
Comment single values following an expression, that may or may not be part of it.
Remove unused but set variables, keep code when it makes sense
Add a missing const qualifier in parent class
Remove test if it does not make sens or is indeed trivial, fix it by changing variable type when it makes sense
RAND_MAX+1 overflows, so divide by RAND_MAX
use std::cout instead of fprintf, treat string as an argument in snprintf
use value 32767 instead of 65535 for undefined to fit a short
Lgt2x
commented
May 21, 2025
| int i; | ||
| for (i = 0; i < MAX_PLAYER_WEAPONS; i++) { | ||
| if (HAS_FLAG(i)) { | ||
| if (HAS_FLAG(i) != 0) { |
Member
Author
There was a problem hiding this comment.
looking at it again this test makes no sense, may as well remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve a bunch of clang warnings. The core of the leftover warnings are "unused-X" that need evaluation, char subscripts and C++ function signatures exported with C linkage.
For removed code, I kept relevant logic when it made sense, while keeping execution logic unchanged.