align/merge vector and vector_array types#674
Merged
Lgt2x merged 1 commit intoDescentDevelopers:mainfrom Mar 6, 2025
jopadan:main
Merged
align/merge vector and vector_array types#674Lgt2x merged 1 commit intoDescentDevelopers:mainfrom jopadan:main
Lgt2x merged 1 commit intoDescentDevelopers:mainfrom
jopadan:main
Conversation
Lgt2x
reviewed
Feb 28, 2025
Member
|
The macos CI found new warnings caused by these changes : https://github.com/DescentDevelopers/Descent3/actions/runs/13578120176/job/38006605278?pr=674#step:14:179 Mac and Windows also have build failures: |
Author
|
@Lgt2x: typedef std::make_signed<size_t>::type ssize_t;
return matrix{(T)1,(T)2,(T)3}; |
Member
|
The last comments from me are nitpicking from me, this is good enough. It plays fine on Linux. Thanks again @jopadan , this vector interface is much better than what we had! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
The game Freespace 2 uses a more advanced Volition vecmat library than Descent 3.
Checklist