Skip to content

Initialize DLLcf_* function pointers in con_dll.h#668

Merged
Lgt2x merged 1 commit intoDescentDevelopers:mainfrom
arbruijn:condll-dllcf
Feb 23, 2025
Merged

Initialize DLLcf_* function pointers in con_dll.h#668
Lgt2x merged 1 commit intoDescentDevelopers:mainfrom
arbruijn:condll-dllcf

Conversation

@arbruijn
Copy link
Contributor

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Starting or joining a multiplayer game crashes the game. It looks like commit f5d2a43 (Add -aditionaldir option) did not add intialization of the new DLLcf_* function pointers to con_dll.h. This causes a crash in StartMultiplayerGameMenu() when it looks for *.d3m files with DLLcf_LocateMultiplePaths (and later when it looks for the settings file folder with DLLcf_GetWritableBaseDirectory).

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

Copy link
Member

@halprin halprin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this issue myself. I tested this and it works on macOS. @arbruijn mentioned this in Discord.

Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@Lgt2x Lgt2x merged commit 9efad71 into DescentDevelopers:main Feb 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants