Introduce cross-compiled ARM64 build#642
Merged
winterheart merged 8 commits intoDescentDevelopers:mainfrom Nov 29, 2024
Merged
Conversation
1ae831d to
935dbc4
Compare
Due to a bug in DBUS and its VCPKG port VCPKG#40031, DBUS cannot be cross-compiled.
winterheart
reviewed
Nov 1, 2024
Comment on lines
+99
to
+101
| pushd builds/linux/ | ||
| ninja -f build-${{ matrix.build_type }}.ninja HogMaker | ||
| popd |
Collaborator
There was a problem hiding this comment.
This can be simpified with
ninja -f build-${{ matrix.build_type }}.ninja -C builds/linux/ HogMaker
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Using the HogMaker build changes of #637 , introduce an example of cross-compilation to ARM64. This also serves as non-regression automated build for this type of compilation.
The changes to
vcpkg.jsonare due to a VCPKG issue causing dbus cross-compilation to fail. The best solution would be to report the issue upstream to dbus, but for the time being, we simply disable the optional SDL2 dependency to dbus.find_package(HogMaker)is now in top-levelCMakeLists.txt, because otherwise the exported targets would not be found.The changes
Checklist
Additional Comments