Hogmaker: Only rebuild the hog file if any input file changed#635
Closed
sebholt wants to merge 1 commit intoDescentDevelopers:mainfrom
Closed
Hogmaker: Only rebuild the hog file if any input file changed#635sebholt wants to merge 1 commit intoDescentDevelopers:mainfrom
sebholt wants to merge 1 commit intoDescentDevelopers:mainfrom
Conversation
Collaborator
|
I would like to retain ability to generate hog file no matter of what in cmd-line. Still, I understand your intentions and can propose alternative based on properly cmake dependencies detection. In result all hog files will be generated only if any of packed files was changed. |
Contributor
Author
That'd be great. I'd prefer a CMake based solution which integrates into the build system more nicely. |
Contributor
Author
|
I'm closing this PR because we have a better CMake based solution in #637. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This lets the hogmaker (re)build the hogfile only if
otherwise only "Already up to date" is printed.
In the build process this
Also some unused code is removed from the hogmaker.
Related Issues
Screenshots (if applicable)
Checklist
Additional Comments