Use POSIX instead of __LINUX__ for general OS checks#492
Merged
winterheart merged 4 commits intoDescentDevelopers:mainfrom Jul 15, 2024
Merged
Use POSIX instead of __LINUX__ for general OS checks#492winterheart merged 4 commits intoDescentDevelopers:mainfrom
POSIX instead of __LINUX__ for general OS checks#492winterheart merged 4 commits intoDescentDevelopers:mainfrom
Conversation
Steps: ```sh srcs=$(mktemp) find . -name "*.cpp" -or -name "*.c" -or -name "*.h" -or -name "*.hpp" -or -name "*.cc" -or -name "*.hh" > $srcs xargs sed -i 's/ifndef __LINUX__/if !defined(POSIX)/' < $srcs xargs sed -i 's/ifdef __LINUX__/if defined(POSIX)/' < $srcs xargs sed -i 's/defined(__LINUX__)/defined(POSIX)/' < $srcs ```
tophyr
changed the title
POSIX instead of __LINUX__ for general OS checks
Lgt2x
approved these changes
Jul 14, 2024
Member
Lgt2x
left a comment
Lgt2x
left a comment
There was a problem hiding this comment.
I'm fine with this change, @winterheart could you please also take a look?
Collaborator
|
Tested on Linux (SP/MP), runs fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Per discussion in #459 (comment), this PR changes the way platform
#definemacros are set up so that we don't need to use__LINUX__to represent any linux-ey system.Changes were tested using unifdef to process the entire codebase at the base and tip of the branch. No differences were found after running the preprocessor with appropriate defines before and after, meaning that the compiled code is identical (as intended).
Checklist
Additional Comments