Closed
Conversation
Contributor
Author
|
Will need reconciliation with #457 |
Member
|
why not using VCPKG? And we probably don't want SDL unstable master branch |
Member
|
As discussed on Discord, I'd prefer a unified VCPKG-based solution for our external packages. We don't have a tangible reason to require a personalized (and master branch) SDL2 build right now. VCPKG can apparently be used for Android, and compile libraries in debug mode if we need to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Use SDL as a git submodule, and incorporate the project directly into our build instead of relying on a prebuilt library provided by a package manager or system configuration. This will enable us to build SDL precisely to our needs, for our build target.
Checklist