Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Theglassofdata to examples #373

Merged
merged 5 commits into from
Feb 1, 2025

Conversation

Theglassofdata
Copy link
Contributor

Summary

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

README.md Outdated
@@ -205,3 +205,5 @@ Made with ❤️ and PHP
<!-- markdownlint-enable MD033 -->

This project uses [Twemoji](https://github.com/twitter/twemoji), published under the [CC-BY 4.0 License](https://creativecommons.org/licenses/by/4.0/)

[![Say my name](https://github.com/Theglassofdata.png?size=60)](https://github.com/Theglassofdata "Say my name")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you put this line around between 133 and 134 so it is in the right section

You can update it on your branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Its updated.

@DenverCoder1 DenverCoder1 merged commit 9e9d48d into DenverCoder1:main Feb 1, 2025
2 checks passed
@DenverCoder1 DenverCoder1 changed the title Added my profile to README docs: Add Theglassofdata to examples Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants