Add Laravel sail for dev container #47
Conversation
Signed-off-by: Eddie Zaneski <[email protected]> Co-authored-by: Casey Hunger <[email protected]>
| if (config('app.env') == 'local') { | ||
| Log::warning('APP_ENV is local, skipping mTLS check for Slack'); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Is there a better way to do this? ngrok has an mTLS module but it's kinda a pain.
There was a problem hiding this comment.
App::environment('local') for the command to check if you're running locally. Personally, if you're testing locally there's not too much reason to verify the Slack cert unless you leave that tunnel open.
| if (config('app.env') == 'local') { | ||
| Log::warning('APP_ENV is local, skipping mTLS check for Slack'); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
App::environment('local') for the command to check if you're running locally. Personally, if you're testing locally there's not too much reason to verify the Slack cert unless you leave that tunnel open.
|
|
||
| ]; | ||
|
|
||
| foreach($memberships as [$customerId, $planIds]) { |
There was a problem hiding this comment.
fwiw, this isn't a customer id but it's a full blown customer. Laravel will translate the model to the id for you.
There was a problem hiding this comment.
That's what I expected too, but when I used it as a customer object it failed, and subsequent logging suggested it was just returning an ID. IDK what I was doing wrong but this works. How do you recommend we change it?
| } | ||
| Log::info('CustomerSeeder: Seeding Customers and UserMemberships.'); | ||
|
|
||
| $superuser = Customer::factory() |
There was a problem hiding this comment.
What's the point of the super user, out of curiosity. It just seems like they've been given all the training here so I'm wondering if that means it must be updated whenever we hardcode a new membership plan.
There was a problem hiding this comment.
The super user is a user that you can use to not have to worry about not having permissions for things. It's a good starting point to discovering/testing functionality without being restricted by lack of permissions. If you want to test/add functionality that it doesn't have, yes, you'll need to update it. Seed maintenance is a thing, but it shouldn't be a big lift. If someone wants to automate it further, that would certainly be welcome. This is just a starting point so that you don't have to go craft the first user in a blank database and figure out what all it needs in order to be functional. Seeds also serve as quick-start examples of what data affects a change in functionality.
|
@eddiezane can you add the cliffnotes of the development guide here? I haven't been able to run this yet and I don't really want to go read more documentation right now to figure it out. Presumably I need to install php and composer, run composer install, and then run some sail commands to start this version? |
|
@eddiezane This PR is out of date in that it's not merge-able due to the lock file. I'm wondering if we should split out the factories work from the Laravel Sail work. What are your thoughts? Personally, I've been using Laravel Herd for my environment, but I only see that available on Windows/Mac. |
This PR adds Laravel sail to add a dev container to the project.
It also adds database seeds for local development.
We will follow up with a development guide in another PR.