Skip to content

Add Sail and add install instructions to readme #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add Sail and add install instructions to readme #135

wants to merge 10 commits into from

Conversation

michaeljhopkins
Copy link
Collaborator

No description provided.

Jnesselr
Jnesselr reviewed May 25, 2025
View reviewed changes
Copy link
Member

@Jnesselr Jnesselr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.json minimum PHP version is 8.2, any reason to include the 8.0 and 8.1 docker files? I haven't tested this just yet, but so far everything looks good with a quick glance through.

@michaeljhopkins
Copy link
Collaborator Author

composer.json minimum PHP version is 8.2, any reason to include the 8.0 and 8.1 docker files? I haven't tested this just yet, but so far everything looks good with a quick glance through.

Sloppy coding. Removing them is a smart call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jnesselr Jnesselr Jnesselr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljhopkins @Jnesselr