Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From MuData to SpatialData #319

Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

From MuData to SpatialData #319

wants to merge 57 commits into from

Conversation

SarahOuologuem
Copy link
Collaborator

Hi!
I adjusted both the Ingestion and the Preprocessing to SpatialData. I also added the ingestion for xenium
I can, as a next step, adjust the github actions and tutorials.

@SarahOuologuem SarahOuologuem added the enhancement New feature or request label Nov 12, 2024
@SarahOuologuem SarahOuologuem marked this pull request as draft November 12, 2024 08:42


### dependencies
- pinned "spatialdata==0.2.6", "spatialdata-io==0.1.6", "dask==2024.12.1" as temporary fix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these versions?

import os
from pathlib import Path
"""
this script copies the make_adata_from_csv.py that creates
ONE MUDATA PER SAMPLE, with in each ONE LAYER per modality
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment up to date?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no! i can update it

@bio-la bio-la marked this pull request as ready for review February 12, 2025 08:34
@bio-la bio-la self-requested a review February 12, 2025 08:34
L.info("Reading in SpatialData from '%s'" % args.input_spatialdata)
sdata = sd.read_zarr(args.input_spatialdata)
#mdata = mu.read(args.input_spatialdata)
#spatial = mdata.mod['spatial']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it expected that at this checkpoint you don't offer the option to read a mudata anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected from what? the plot_qc_spatial.py file gets .zarr files as input from the pipeline in qc and preprocessing

L.info("Reading in spatial MuData from '%s'" % args.input_spatial)
mdata_spatial = mu.read(args.input_spatial)
adata_st = mdata_spatial.mod['spatial']
L.info("Reading in spatial SpatialData from '%s'" % args.input_spatial)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cell2location only accepts spatialData now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. do you want cell2location to also run on MuData/AnnData?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants