Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include scib metrics computation in integration workflow #273

Merged
merged 10 commits into from
Apr 30, 2024

Conversation

Lilly-May
Copy link
Collaborator

@Lilly-May Lilly-May commented Apr 29, 2024

New features:

  • Integrated computation of metrics available via the scib_metrics package
  • Distinguish between data with and without cell type label annotation and compute the respectively available metrics.
  • I tested the function for both data with and without cell type labels.
  • Closes refactoring scib #100.

ToDos:

  • Include scib_metrics in dependencies?
  • Add parameters to integration yaml documentation

As soon as this PR is approved, I will also adapt the pre-filled integration pipeline.yml for the integration tutorial.

@Lilly-May Lilly-May marked this pull request as ready for review April 29, 2024 22:17
@Lilly-May Lilly-May requested a review from bio-la April 29, 2024 22:19
Copy link
Collaborator

@bio-la bio-la left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a section in the changelog.md file to reflect the addition and we're good to go! great job!

@bio-la bio-la merged commit 8dad1b6 into main Apr 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactoring scib
2 participants