Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #246

Merged
merged 52 commits into from
Apr 27, 2024
Merged

Improve logging #246

merged 52 commits into from
Apr 27, 2024

Conversation

SarahOuologuem
Copy link
Collaborator

Hi! I added some logging to the spatial workflows and wanted to check with you @bio-la whether this is what you're thinking of before I continue with the other workflows.

@SarahOuologuem SarahOuologuem requested a review from bio-la March 26, 2024 14:27
Copy link
Collaborator

@bio-la bio-la left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these look good checkpoint messages to me!

@SarahOuologuem SarahOuologuem marked this pull request as draft March 27, 2024 09:30
@bio-la bio-la mentioned this pull request Mar 27, 2024
2 tasks
@SarahOuologuem
Copy link
Collaborator Author

@bio-la I now added
L.info("Running with params: %s", args) to every file instead of L.info(args)

@SarahOuologuem SarahOuologuem requested a review from bio-la April 26, 2024 08:51
@SarahOuologuem SarahOuologuem marked this pull request as ready for review April 26, 2024 08:51
@bio-la bio-la merged commit fb63326 into main Apr 27, 2024
11 checks passed
@bio-la
Copy link
Collaborator

bio-la commented Apr 27, 2024

@SarahOuologuem awesome job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants