fix: add fallback to polyfill when SIMD extensions are missing - #31
Open
moefqy wants to merge 1 commit into
Open
fix: add fallback to polyfill when SIMD extensions are missing#31moefqy wants to merge 1 commit into
moefqy wants to merge 1 commit into
Conversation
Collaborator
|
Thank you @moefqy for this really. I've assigned reviewers to this PR and we will come back to you soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS (specifically x86_64 / Rosetta environments), CPU architecture detection in
deltakit_stimreturnssse2(oravx2), causingdeltakit_stim/__init__.pyto attempt:However, in the pre-built macOS wheel distribution on PyPI (
deltakit_stim-0.2.0-cp311-cp311-macosx_15_0_x86_64.whl),_stim_sse2.sowas omitted during the build, shipping only_stim_polyfill.so.Because there is no exception handler around the import, installing and running
deltakiton macOS raises an unhandled crash:Solution
try...except (ImportError, ModuleNotFoundError)block._stim_sse2is present, it will load for fast SIMD execution._stim_sse2is missing from the installed package, it gracefully falls back to _stim_polyfill instead of crashing.Verification
Tested on macOS 15 (Sequoia, Python 3.11.4):
import deltakitandimport deltakit_stimnow load cleanly without errors.