Remove ion damage

[rebe83]

About the PR

title

Why / Balance

Inspired by https://discord.com/channels/968983104247185448/1511526035089526794
Disablers slowly killing borgs
EMP KILLING borgs instead of just draining battery
It just seems oppressive and was made to punish IPCs which are gone

Technical details

remove siliconemp component from baseborg
remove ion damage from disabler projectiles
edit: remove ion damage profile, electrical damage group, damage variable in emp call functions, siliconemp component and systems

Media

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an in-game showcase.

Licensing

• I confirm that I am the creator of the code in this PR, and allow licensing it under the following license(s), or that the original author(s) has given me permission to do so:
  • AGPL (https://github.com/DeltaV-Station/Delta-v/blob/master/LICENSE-AGPLv3.txt)
  • MIT (https://github.com/DeltaV-Station/Delta-v/blob/master/LICENSE-MIT.txt)

Changelog

🆑

• remove: Cyborgs no longer take ion damage.

[delta-v-bot]

Triaged by kotobdev:
This PR requires a content review discussion, which will be held in public.
The review duration has been set to 3 days.

[NoElkaTheGod]

Pretty sure coscult weapons still deal ion damage along with asphyx, which was the sole reason why I added ion damage in the first place. Do with that what you will.

[MantasDab360]

Pretty sure coscult weapons still deal ion damage along with asphyx, which was the sole reason why I added ion damage in the first place. Do with that what you will.

they're not wrong.

[rebe83]

It's fucking impossible to Ctrl F search ion in the IDE because every instance of "solution" and "administration" "extension" etc comes up
Either way CR seems to want the whole damage type gone anyways so this would need more changes

[Radezolid]

It's fucking impossible to Ctrl F search ion in the IDE because every instance of "solution" and "administration" "extension" etc comes up

Toggle the match whole word filter

[NoElkaTheGod]

It's fucking impossible to Ctrl F search ion in the IDE because every instance of "solution" and "administration" "extension" etc comes up

I think that + coscult stuff is all the cases of ion damage existing. Might have added it to more than just coscult weapons trhough, I think using glyphs also deals ion? Maybe astral nova too.

Either way CR seems to want the whole damage type gone anyways so this would need more changes

Might as well delete the damage type and group too. If I were CR I'd probably still keep it for coscult weapons specifically, because they're absolutely awful against borgs without it (they deal equeal parts of slash/pierce + asphyx + cold, and borgs ignore the latter two, so the strongest melee weapon in the game gets downgraded to a crowbar effectively).

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[rebe83]

It's fucking impossible to Ctrl F search ion in the IDE because every instance of "solution" and "administration" "extension" etc comes up

I think that + coscult stuff is all the cases of ion damage existing. Might have added it to more than just coscult weapons trhough, I think using glyphs also deals ion? Maybe astral nova too.

Either way CR seems to want the whole damage type gone anyways so this would need more changes

Might as well delete the damage type and group too. If I were CR I'd probably still keep it for coscult weapons specifically, because they're absolutely awful against borgs without it (they deal equeal parts of slash/pierce + asphyx + cold, and borgs ignore the latter two, so the strongest melee weapon in the game gets downgraded to a crowbar effectively).

discussion happening rn right this second in CR lol