Basic Airlock Audio Change#5958
Open
IAmNotGray wants to merge 4 commits into
Open
Conversation
holy door! new access just dropped actual maintenance panel call the engineer CE went on vacation, never came back (i'm sorry) Co-Authored-By: darklyac <204901402+darklyac@users.noreply.github.com>
github-actions
Bot
added
size/XS
delta-v-bot
Bot
added
the
Under Direction Review
|
Triaged by stonehanaku: |
how can i laugh at this? there's no google en passant!
Contributor
|
:( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Courtesy of Darklyac, this PR introduces new basic airlock sounds that were meant to be paired with the high security and external sounds that we have now. This is being proposed again after I was given the greenlight by a maintainer. See the original pull request here:
#5621
Why / Balance
The upstream sounds didn't fit then, and the current closing sound we have doesn't fit either now.
Technical details
Shrimple YAML and audio file changes
Media
20260603-2105-35.8632687.mp4
Requirements
Licensing
Changelog
🆑 This_Is_Gray, Darklyac