Revert "feat: Fancy Screenshake from Ephemeral Space (#5503)"

[keekee38]

About the PR

reverting #5503

Why / Balance

it kinda gave me motion sickness and think some other folks were sayin they werent fans of it either

Technical details

Media

its just the old screenshake

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an in-game showcase.

Licensing

• I confirm that I am the creator of the code in this PR, and allow licensing it under the following license(s), or that the original author(s) has given me permission to do so:
  • AGPL (https://github.com/DeltaV-Station/Delta-v/blob/master/LICENSE-AGPLv3.txt)
  • MIT (https://github.com/DeltaV-Station/Delta-v/blob/master/LICENSE-MIT.txt)

Changelog

🆑

• tweak: Changed screenshake back to how it was before

[delta-v-bot]

Triaged by starboundsolaris:
This PR requires a content review discussion, which will be held in private.

DIRECTION KNOWS BEST
DIRECTION KNOWS BEST
DIRECTION KNOWS BEST

The review duration has been set to 7 days.

[turtlemutt]

thank god

[pootslap]

I'm so glad it's not just me. The new screenshake is kinda cool for when stuff hits the station but fighting someone with a knife and causing a huge earthquake every time you swing looks bizarre.

[BarryNorfolk]

This has a dedicated option in settings, I think?

[Axianamos]

It does have an option, which i immediately disabled. I dont think the feature should be removed, but perhaps it would be better to start with it disabled.

[keekee38]

mhmm theres an option in settings but it just disables screenshake entirely, i like screenshake but this one i cant use at all

[DisposableCrewmember42]

Some changes that could be made instead of removing completely:

• It would be possible to use the old screenshake for melee attacks, which I agree looks weird right now.
• We could combine the old screenshake with the new screenshake for explosions so there's some directionality to it again. Starlight has that as a tweak to it, could be ported.
• The severity of the shaking can be tweaked

I do think this new screenshake is far better for shooting than the old one.