Content Warning popup#5953
Open
kotobdev wants to merge 4 commits into
Open
Conversation
* Content warnings (DeltaV-Station#2922) Co-authored-by: funkystationbot <funky@funkystation.org> * lala * fix: content warning should now display * taydeo were these on purpose? * victor hugo mary shelley oscar wilde frankenstein we didnt start the fire --------- Co-authored-by: taydeo <tay@funkystation.org> Co-authored-by: funkystationbot <funky@funkystation.org>
github-actions
Bot
added
S: Needs Review
delta-v-bot
Bot
added
the
Under Direction Review
|
Triaged by cepelinas: |
Contributor
|
how will this affect armory rushing |
Contributor
Direction knows best |
Contributor
|
This is not the place for me. |
Contributor
This is not a place of honor. |
Contributor
|
We should nerf the clown to balance this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Ported the content warning popup from Impstation (which ported it from Funky). impstation/imp-station-14#4373
Why / Balance
In the space game where bad things happen to you, players need to be okay with bad things happening to them. As such, it's best to inform them of such things when they first join.
Wording may need to be adjusted, but it seemed pretty sensible.
Technical details
YOU NEED TO RUN IN RELEASE TO TEST THIS. THE FEATURE IS DISABLED ON DEBUG/TOOLS
the disable in debug bit came from the yet-to-be-merged PR https://github.com/impstation/imp-station-14/pull/4412/changes, hence the imp comments
I kind of eyeballed the xaml fix, the bottom buttons were getting squished together weirdly. There's probably a better way to fix that, but :idk:
Media
Requirements
Licensing
Changelog
🆑